{M,R,L}_star reported for every mode in summary

[warrick]

I ran into this and instinctively opened an issue on GitHub but realised I should probably stick to the forum. This is a copy of what I wrote there, though having looked at the code, I'm not sure how easily I'd be able to restore the old behaviour.

I've just noticed that as of GYRE 6.0 and 6.0.1, the global properties of the stellar model M_star, R_star and L_star are printed for every row in the summary. e.g. using

Code: Select all

summary_item_list = 'M_star,R_star,L_star,l,n_pg,n_p,n_g,freq'

produces outputs with columns

Code: Select all

                        1                         2                         3                         4                         5                         6                         7                         8                         9   ...
                   M_star                    R_star                    L_star                         l                      n_pg                       n_p                       n_g                  Re(freq)                  Im(freq)
  0.1870695448119380E+034   0.9244814222809137E+011   0.5535984490610758E+034                         0                         1                         1                         0   0.1571556553722975E+003   0.0000000000000000E+000
  0.1870695448119380E+034   0.9244814222809137E+011   0.5535984490610758E+034                         0                         2                         2                         0   0.2634269036681596E+003   0.0000000000000000E+000
  0.1870695448119380E+034   0.9244814222809137E+011   0.5535984490610758E+034                         0                         3                         3                         0   0.3554595640873490E+003   0.0000000000000000E+000
...

whereas in previous versions M_star, R_star and L_star appeared once in the header.

I thought this might be an error but the documentation does say that these variables have data type "real(n_j)", so perhaps this is a design choice? If not, I'm happy to set up a pull request to restore the old behaviour.

[rhtownsend]

Hi Warrick --

This is in fact a design choice; although GYRE currently only works with a single stellar model at a time, the output code can support multiple models. Hence, I decided it made more sense to have {M,R,L} be arrays.

cheers,

Rich

[warrick]

Fair enough! I closed my issue.